Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deno Deploy guide #1081

Merged
merged 17 commits into from
Jul 20, 2024
Merged

Update Deno Deploy guide #1081

merged 17 commits into from
Jul 20, 2024

Conversation

dcdunkan
Copy link
Member

No description provided.

@dcdunkan dcdunkan added ready for translation Translator intervention is required. and removed ready for translation Translator intervention is required. labels Jun 18, 2024
@dcdunkan dcdunkan requested review from rojvv, Loskir and KnorpelSenf June 18, 2024 12:35
Copy link

github-actions bot commented Jun 18, 2024

@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 12:39 Inactive
4. [Create an access token](https://dash.deno.com/account#access-tokens).
5. Run the following command:
1. Install [`deployctl`](https://github.com/denoland/deployctl).
2. Create an access token from the "Access Tokens" section in [account settings](https://dash.deno.com/account).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The access-token anchor was removed due to the page's lazy loading behavior, so that link-checker doesn't have to be configured to check for the anchor. I think the information is good enough. But if it needs to be reverted, let me know, I can adjust link-checker to ignore this anchor.

@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 12:52 Inactive
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 16:52 Inactive
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a bunch!

site/docs/hosting/deno-deploy.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 17:47 Inactive
@KnorpelSenf
Copy link
Member

@dcdunkan is this ready for a final review?

@github-actions github-actions bot temporarily deployed to pull request June 29, 2024 22:27 Inactive
@dcdunkan
Copy link
Member Author

dcdunkan commented Jul 1, 2024

Yes, once the conversation is resolved.

@dcdunkan dcdunkan requested a review from KnorpelSenf July 3, 2024 10:14
@github-actions github-actions bot temporarily deployed to pull request July 3, 2024 10:17 Inactive
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quadratz quadratz removed their assignment Jul 15, 2024
@quadratz quadratz requested a review from a user July 15, 2024 01:46
@niusia-ua niusia-ua requested a review from LWJerri July 15, 2024 06:17
@github-actions github-actions bot temporarily deployed to pull request July 15, 2024 06:19 Inactive
Remove text
@github-actions github-actions bot temporarily deployed to pull request July 16, 2024 01:04 Inactive
@ghost
Copy link

ghost commented Jul 16, 2024

@quadratz You forgot to delete "Method 3". But, it's okay. I already deleted it.

@ghost ghost requested a review from quadratz July 16, 2024 01:14
Copy link
Collaborator

@LWJerri LWJerri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@quadratz quadratz added the 🇮🇩 ID Modifies or is related to the Indonesian translations. label Jul 16, 2024
@niusia-ua niusia-ua added the 🇺🇦 UK Modifies or is related to the Ukrainian translations. label Jul 16, 2024
@grammyz grammyz added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label Jul 17, 2024
@github-actions github-actions bot temporarily deployed to pull request July 18, 2024 17:42 Inactive
@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jul 20, 2024
@rojvv rojvv added this pull request to the merge queue Jul 20, 2024
Merged via the queue into main with commit 3bc74a4 Jul 20, 2024
4 of 5 checks passed
@rojvv rojvv deleted the deploy branch July 20, 2024 19:19
@github-actions github-actions bot temporarily deployed to pull request July 20, 2024 19:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. ready for translation Translator intervention is required. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants