-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deno Deploy guide #1081
Update Deno Deploy guide #1081
Conversation
🚀 Deployed on https://669c0e22710cf526d4257a5b--grammy.netlify.app |
site/docs/hosting/deno-deploy.md
Outdated
4. [Create an access token](https://dash.deno.com/account#access-tokens). | ||
5. Run the following command: | ||
1. Install [`deployctl`](https://github.com/denoland/deployctl). | ||
2. Create an access token from the "Access Tokens" section in [account settings](https://dash.deno.com/account). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The access-token
anchor was removed due to the page's lazy loading behavior, so that link-checker doesn't have to be configured to check for the anchor. I think the information is good enough. But if it needs to be reverted, let me know, I can adjust link-checker to ignore this anchor.
Co-authored-by: KnorpelSenf <shtrog@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a bunch!
@dcdunkan is this ready for a final review? |
Yes, once the conversation is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Remove text
@quadratz You forgot to delete "Method 3". But, it's okay. I already deleted it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.