Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tagsAsFields #5

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Default tagsAsFields #5

merged 1 commit into from
Nov 8, 2021

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Nov 4, 2021

Closes #4

@codebien
Copy link
Collaborator Author

codebien commented Nov 5, 2021

@mstoykov In this way, I expect a less stressed system during k6 run (e.g. in the basic case K6_INFLUXDB_ORG .... ./k6+influxdb run --out=http://localhost:8086 script.js). Less indexed fields to maintain for InfluxDB during the writing stage. If the user hits some performance issues during queries or needs to query heavily some not indexed field then s/he can still change the configuration.
Let me know if you think some other fields are heavily used for query data in common cases.

@mstoykov
Copy link
Contributor

mstoykov commented Nov 5, 2021

I don't think that everything needs to be a field. Arguably name should probably be an index so it can be used for better queries.
I would also say that method and status also will likely be used for queries all the time.

Looking at the list of tags here, I am not particularly certain there are any we should ... add to the list as most of those have a very small set of values or will be very important to make queries on like name

@codebien
Copy link
Collaborator Author

codebien commented Nov 5, 2021

I would also say that method and status also will likely be used for queries all the time.

They are already excluded from the list so they would be indexed.

Looking at the list of tags here, I am not particularly certain there are any we should

So would you prefer to have just "vu:int", "iter:int", "url"?

@codebien codebien changed the base branch from output to main November 8, 2021 09:23
vu and iter fields are now represents as int.
@codebien
Copy link
Collaborator Author

codebien commented Nov 8, 2021

@mstoykov updated the PR with the original proposal from the issue description

@codebien codebien merged commit eabd2d8 into main Nov 8, 2021
@codebien codebien deleted the default-types branch November 8, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss whether to not move some fields to be int
2 participants