This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Update to latest k6 and fixes for timeseries #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
approved these changes
Oct 5, 2022
Updates #279
|
The 1.16.x tests were not passing for some dependency reason, so I decided to just bump the go version across the CI while I am at it. Also see grafana/k6#2474 for a bug that only gets fixed by going to go 1.19 |
inancgumus
approved these changes
Oct 5, 2022
imiric
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Thanks! 🙇
So this mostly closes #279, and what's left would be to do the interface{} to any change, as well as test the CI release process. We still anticipate release failures caused by Go 1.18, similar to what happened in grafana/k6#2588, right?
|
I am porting grafana/k6#2591 to xk6-browser, but maybe I can do that in a separate PR as that will also ... update a bunch of stuff |
|
@mstoykov Thanks, a separate PR would make more sense for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.