feat(resource_folder): add retryable validation of parent_folder_uid existence #2041
+15
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating nested Grafana folders using Terraform, Terraform did not guarantee parent folders were made before their child folders. This resulted in 404 errors when creating child folders before their parents existed.
This issue occurs because Terraform does not strictly enforce resource creation order, even when defining a parent-child relationship via parent_folder_uid in the same resource within a loop.
Solution
GetFolderByIDorUID
to allow Terraform time to create it.Changes summary:
GetFolderByIDorUID
before creating the child folder.retry.RetryContext
to repeatedly check for the parent folder’s existence before attempting to create the child folder.Terraform code example
Output before this change
Output after this change