Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource_access_policy): Add support for allowed_subnets #2007

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lrsmith-dev
Copy link

@lrsmith-dev lrsmith-dev commented Jan 29, 2025

Pull Request to extend the Grafana Access Policy Resource to support defining a conditions block and allowed_subnets.

This PR addresses closes #1790

@lrsmith-dev lrsmith-dev requested review from a team as code owners January 29, 2025 03:10
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@lrsmith-dev lrsmith-dev force-pushed the feat_resource_access_policy_allowed_subnets branch from 30a5321 to ac0f03c Compare January 29, 2025 03:10
@spinillos
Copy link
Member

@grafana/grafana-com-maintainers could you review this?

Copy link
Contributor

@mgyongyosi mgyongyosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a small suggestion because IP range based access control is not supported everywhere.

Copy link
Member

@cinaglia cinaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look reasonable to me from an IAM perspective. I'd just suggest double checking for lint issues and running the command to generate the docs.

@lrsmith-dev lrsmith-dev force-pushed the feat_resource_access_policy_allowed_subnets branch from ccca06e to 516ef65 Compare February 24, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add conditions support to grafana_cloud_access_policy_token
5 participants