-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resource_access_policy): Add support for allowed_subnets #2007
base: main
Are you sure you want to change the base?
feat(resource_access_policy): Add support for allowed_subnets #2007
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
30a5321
to
ac0f03c
Compare
@grafana/grafana-com-maintainers could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, left a small suggestion because IP range based access control is not supported everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look reasonable to me from an IAM perspective. I'd just suggest double checking for lint issues and running the command to generate the docs.
ccca06e
to
516ef65
Compare
Pull Request to extend the Grafana Access Policy Resource to support defining a conditions block and allowed_subnets.
This PR addresses closes #1790