chore(slo provider): update failure for prometheus queries in grafana…

…Queries
grafana · Feb 18, 2025 · b0ee9a4 · b0ee9a4
1 parent 3c90dc7
commit b0ee9a4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/internal/resources/slo/resource_slo.go b/internal/resources/slo/resource_slo.go
@@ -720,6 +720,12 @@ func ValidateBigTent() schema.SchemaValidateDiagFunc {
 		var gmrQuery []map[string]any
 		err := json.Unmarshal([]byte(v), &gmrQuery)
 		if err != nil {
+			diags = append(diags, diag.Diagnostic{
+				Severity:      diag.Error,
+				Summary:       "Missing Required Field",
+				Detail:        fmt.Sprintf("expected grafana queries to be valid JSON format"),
+				AttributePath: path,
+			})
 			return diags
 		}
 

diff --git a/internal/resources/slo/resource_slo_test.go b/internal/resources/slo/resource_slo_test.go
@@ -426,8 +426,13 @@ func TestValidateBigTent(t *testing.T) {
 		expectedDiags diag.Diagnostics
 	}{
 		"prometheus": {
-			query:         "sum(rate(apiserver_request_total{code!=\"500\"}[$__rate_interval])) / sum(rate(apiserver_request_total[$__rate_interval]))",
-			expectedDiags: diag.Diagnostics{},
+			query: "sum(rate(apiserver_request_total{code!=\"500\"}[$__rate_interval])) / sum(rate(apiserver_request_total[$__rate_interval]))",
+			expectedDiags: diag.Diagnostics{diag.Diagnostic{
+				Severity:      diag.Error,
+				Summary:       "Missing Required Field",
+				Detail:        fmt.Sprintf("expected grafana queries to be valid JSON format"),
+				AttributePath: cty.IndexPath(cty.Value{}),
+			}},
 		},
 		"bigTent_success": {
 			query:         createBigTent(true, []map[string]any{}),