Wip

grafana · Jan 27, 2025 · 6b6203b · 6b6203b
1 parent 6b36d7f
commit 6b6203b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 16 deletions.
diff --git a/packages/create-plugin/package.json b/packages/create-plugin/package.json
@@ -37,7 +37,7 @@
     "generate-datasource-backend": "tsc && npm run clean-generated && CREATE_PLUGIN_DEV=true node ./dist/bin/run.js --pluginName='Sample datasource' --orgName='sample-org' --pluginType='datasource' --hasBackend",
     "lint": "eslint --cache ./src",
     "lint:fix": "npm run lint -- --fix",
-    "test": "vitest",
+    "test": "vitest --passWithNoTests",
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
@@ -88,4 +88,4 @@
   "engines": {
     "node": ">=20"
   }
-}
+}
diff --git a/packages/create-plugin/src/migrations/migrations.ts b/packages/create-plugin/src/migrations/migrations.ts
@@ -10,10 +10,11 @@ type Migrations = {
 
 export default {
   migrations: {
-    'add-webpack-profile': {
-      version: '5.13.0',
-      description: 'Update build command to use webpack profile flag.',
-      migrationScript: './scripts/add-webpack-profile.js',
-    },
+    // Example migration entry (DO NOT UNCOMMENT!)
+    // 'example-migration': {
+    //   version: '5.13.0',
+    //   description: 'Update build command to use webpack profile flag.',
+    //   migrationScript: './scripts/example-migration.js',
+    // },
   },
 } as Migrations;
diff --git a/...tions/scripts/add-webpack-profile.test.ts → ...rations/scripts/example-migration.test.ts b/...tions/scripts/add-webpack-profile.test.ts → ...rations/scripts/example-migration.test.ts
@@ -1,7 +1,7 @@
 // ONLY FOR DRAFT - DELETE BEFORE MERGE
 // -------------------------------------
 
-import migrate from './add-webpack-profile.js';
+import migrate from './example-migration.js';
 import { createDefaultContext } from '../test-utils.js';
 
 describe('Migration - append profile to webpack', () => {

diff --git a/...migrations/scripts/add-webpack-profile.ts → ...c/migrations/scripts/example-migration.ts b/...migrations/scripts/add-webpack-profile.ts → ...c/migrations/scripts/example-migration.ts
@@ -1,10 +1,6 @@
-// ONLY FOR DRAFT - DELETE BEFORE MERGE
-// -------------------------------------
-
 import type { Context } from '../context.js';
 
 export default function migrate(context: Context): Context {
-  // UPDATING ----
   const rawPkgJson = context.getFile('./package.json') ?? '{}';
   const packageJson = JSON.parse(rawPkgJson);
 
@@ -20,22 +16,18 @@ export default function migrate(context: Context): Context {
     context.updateFile('./package.json', JSON.stringify(packageJson, null, 2));
   }
 
-  // DELETING ----
   if (context.doesFileExist('./src/README.md')) {
     context.deleteFile('./src/README.md');
   }
 
-  // ADDING ----
   if (!context.doesFileExist('./src/foo.json')) {
     context.addFile('./src/foo.json', JSON.stringify({ foo: 'bar' }));
   }
 
-  // RENAME ---
   if (context.doesFileExist('.eslintrc')) {
     context.renameFile('.eslintrc', '.eslint.config.json');
   }
 
-  // READ DIR ---
   context.readDir('./src');
 
   return context;