Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): fix .golangci.yaml config file #16368

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

JoaoBraveCoding
Copy link
Collaborator

What this PR does / why we need it:

Fix linter config see https://github.com/grafana/loki/actions/runs/13397383118/job/37419714676?pr=16360
Changes:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@xperimental
Copy link
Collaborator

@JoaoBraveCoding Should we add a call to golangci-lint config verify to the make lint target, so that we don't run into this again?

@xperimental xperimental merged commit f3ce689 into grafana:main Feb 19, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants