fix(blooms): Initialize bloom gateway client only once (backport release-3.4.x) #16268
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![loki-gh-app[bot]](https://avatars.githubusercontent.com/u/7195757?s=60&v=4){kind=small}
The bloom gateway client is used both in the bloom builder and in the index gateways. When running Loki in SSD mode, both services are part of the backend target, and therefore the client is initialised twice, leading to duplicate metrics registration and a subsequent panic. This commit extracts the initialisation of the bloom gateway client into a separate service that is started once and becomes a dependency of both bloom builder and index gateway. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit e271e22)
loki-gh-app
bot
added
backport
size/M
type/bug
chaudum
approved these changes
Feb 14, 2025
This was referenced Feb 14, 2025
|
backport-15994-to-release-3.4.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e271e22 from #15994
What this PR does / why we need it:
The bloom gateway client is used both in the bloom builder and in the index gateways. When running Loki in SSD mode, both services are part of the
backendtarget, and therefore the client is initialised twice, leading to duplicate metrics registration and a subsequent panic.This commit extracts the initialisation of the bloom gateway client into a separate service that is started once and becomes a dependency of both bloom builder and index gateway.
Which issue(s) this PR fixes:
Fixes: #14083