fix: change object_store.prefix to object_store.storage_prefix in helm #16266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@icylord can you also sign the CLA? you might have to amend the existing commits to match the github email id :) |
already fixed. thanks for the remind |
ashwanthgoli
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
lgtm
@icylord can you also update the docs and add a changelog entry before I can merge this?
https://github.com/grafana/loki/actions/runs/13342965178/job/37316522282
make -C docs sources/setup/install/helm/reference.md
github-actions
bot
added
the
type/docs
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to doc: https://grafana.com/docs/loki/v3.4.x/configure/#thanos_object_store_config
the field for prefix for storage keys is
storage_prefixnotprefix, this will cause helm deploy fail loading config.