Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(promtail): windows forward event crash (backport k239) #16163

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Feb 10, 2025

Backport 82cfaea from #16155


What this PR does / why we need it:

In Alloy we are still using the win_eventlog pkg from Promtail and a user reported that some windows events would make Alloy crash during ingestion (grafana/alloy#2616).

During the investigation, I found out that this code was taken from Telegraf and that this is a problem that they encountered and solved via influxdata/telegraf#12375.

I ported the fix to my local loki and built a custom Alloy version with it. The user tested and reported that the bug was solved: grafana/alloy#2616 (comment)

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot added the backport label Feb 10, 2025
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner February 10, 2025 16:32
@loki-gh-app loki-gh-app bot added size/M type/bug Somehing is not working as expected labels Feb 10, 2025
@loki-gh-app loki-gh-app bot requested a review from cyriltovena February 10, 2025 16:32
@paul1r paul1r enabled auto-merge (squash) February 10, 2025 16:34
@paul1r paul1r merged commit 9dda5bf into k239 Feb 10, 2025
64 checks passed
@paul1r paul1r deleted the backport-16155-to-k239 branch February 10, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants