Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(operator): Update OTLP user guide to reflect change in LokiStack #16057

Merged
merged 5 commits into from
Feb 13, 2025
Merged

fix(operator): Update OTLP user guide to reflect change in LokiStack #16057

merged 5 commits into from
Feb 13, 2025

Conversation

xperimental
Copy link
Collaborator

What this PR does / why we need it:

Follow-up of #15857 updating the documentation to match.

Which issue(s) this PR fixes:

Refs LOG-6507

Special notes for your reviewer:

  • I think this PR represents the minimal change we need, so that the documentation matches the operator's reality again. While reading through the article again, I noticed that it might need further improvement, which this PR does not include (yet). We can either wait until this change is included in this PR or split the rework of the article out into a separate PR, I'm fine either way.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Title matches the required conventional commits format, see here

@xperimental xperimental self-assigned this Feb 3, 2025
JoaoBraveCoding
JoaoBraveCoding approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoaoBraveCoding JoaoBraveCoding merged commit 14e2c87 into grafana:main Feb 13, 2025
66 checks passed
@xperimental xperimental deleted the otlp-docs branch February 13, 2025 17:31
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 17, 2025
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Feb 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

@periklis periklis Awaiting requested review from periklis periklis is a code owner

Assignees

@xperimental xperimental

Labels
sig/operator size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xperimental @JoaoBraveCoding