Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Add support for Swift TLS CA configuration #15260

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Dec 4, 2024

What this PR does / why we need it:

Bring back #11708 now that #11672 is merged. Tested ✅

Which issue(s) this PR fixes:

Fixes LOG-4820

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • Title matches the required conventional commits format, see here

@JoaoBraveCoding JoaoBraveCoding marked this pull request as ready for review December 4, 2024 18:54
@xperimental
Copy link
Collaborator

Implementation works ✔️

I'm waiting with the merge until the Loki 3.4.2 update is merged, because this change depends on the CLI option being available.

Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💌

@JoaoBraveCoding JoaoBraveCoding merged commit 62a72f6 into grafana:main Feb 19, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants