-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move metric aggregation to a per-tenant config #14709
Conversation
This PR must be merged before a backport PR will be created. |
f.BoolVar( | ||
&l.MetricAggregationEnabled, | ||
"limits.metric-aggregation-enabled", | ||
false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could/should we default this to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make the deployment easier. My big concern is the surprise for OSS users, as I'd still consider it a beta
/experimental
feature.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14709-to-k226 origin/k226
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c1fde26730b4fc54e4bbc724d1b29f653541f720 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14709-to-k226
# Create the PR body template
PR_BODY=$(gh pr view 14709 --json body --template 'Backport c1fde26730b4fc54e4bbc724d1b29f653541f720 from #14709{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'feat: move metric aggregation to a per-tenant config (backport k226)' --body-file - --label 'size/L' --label 'type/docs' --label 'product-approved' --label 'backport' --base k226 --milestone k226 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14709-to-k226
# Create a pull request where the `base` branch is `k226` and the `compare`/`head` branch is `backport-14709-to-k226`.
# Remove the local backport branch
git switch main
git branch -D backport-14709-to-k226 |
(cherry picked from commit c1fde26)
What this PR does / why we need it:
This moves the metric aggregation feature flag to a per-tenant config
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR