-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(alert): clarify remote rule evaluation #14481
docs(alert): clarify remote rule evaluation #14481
Conversation
478ff18
to
7c14df9
Compare
7c14df9
to
65c1f00
Compare
c8be8c8
to
657bb1f
Compare
657bb1f
to
eadb50c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM, thanks for taking the time to update the docs.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14481-to-release-3.0.x origin/release-3.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d63fbeddff238bffdf0abd8866a582049ea37058 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14481-to-release-3.0.x
# Create the PR body template
PR_BODY=$(gh pr view 14481 --json body --template 'Backport d63fbeddff238bffdf0abd8866a582049ea37058 from #14481{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'docs(alert): clarify remote rule evaluation (backport release-3.0.x)' --body-file - --label 'size/M' --label 'type/docs' --label 'backport' --base release-3.0.x --milestone release-3.0.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14481-to-release-3.0.x
# Create a pull request where the `base` branch is `release-3.0.x` and the `compare`/`head` branch is `backport-14481-to-release-3.0.x`.
# Remove the local backport branch
git switch main
git branch -D backport-14481-to-release-3.0.x |
Co-authored-by: J Stickler <julie.stickler@grafana.com> (cherry picked from commit d63fbed)
Co-authored-by: J Stickler <julie.stickler@grafana.com> (cherry picked from commit d63fbed)
Co-authored-by: J Stickler <julie.stickler@grafana.com> (cherry picked from commit d63fbed)
What this PR does / why we need it:
When scrolling alerting documentation, ruler remote evaluation is not mentioned, and for me, it solved many issues, so it would be great to have it in alerting docs.
Which issue(s) this PR fixes:
Fixes #14441
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR