Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add myself and quentin as codeowners/maintainers of the loki-mixin #14274

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cstyan
Copy link
Contributor

@cstyan cstyan commented Sep 25, 2024

Adds myself and @QuentinBisson as codeowners for the loki-mixin. Mostly relevant for reviewing dashboard changes. Quentin I haven't kept up at all with the helm chart so if you should be listed for /production/helm as well LMK.

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan cstyan requested a review from a team as a code owner September 25, 2024 20:18
@QuentinBisson
Copy link
Contributor

QuentinBisson commented Sep 25, 2024

If the team is fine with me being a maintainer of the chart, I would love to be able to help there as well as we use it quite extensively :)

Thanks for adding me to the mixins ;)

@cstyan
Copy link
Contributor Author

cstyan commented Sep 25, 2024

It looks like Github doesn't like having anyone without write access to the repo in the CODEOWNERS file. Alternatively we could update MAINTAINERS.md. I don't know enough of the helm stuff to list you for that but that can be updated as well in the future.

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan cstyan changed the title add myself and quentin as codeowners of the loki-mixin chore: add myself and quentin as codeowners/maintainers of the loki-mixin Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants