Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: J Stickler <julie.stickler@grafana.com>
  • Loading branch information
Jayclifford345 and JStickler authored Oct 29, 2024
1 parent 3c3f801 commit 905551b
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 7 additions & 7 deletions docs/sources/setup/install/helm/install-monolithic/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,8 @@ loki:
period: 24h
storage_config:
aws:
region: <AWS region your bucket is in eg. `eu-west-2`>
bucketnames: <Your AWS bucket for chunk eg. `aws-loki-dev-chunk`>
region: <AWS region your bucket is in, for example, `eu-west-2`>
bucketnames: <Your AWS bucket for chunk, for exaxmple, `aws-loki-dev-chunk`>
s3forcepathstyle: false
pattern_ingester:
enabled: true
Expand All @@ -252,9 +252,9 @@ loki:
storage:
type: s3
bucketNames:
chunks: <Your AWS bucket for chunk eg. `aws-loki-dev-chunk`>
ruler: <Your AWS bucket for ruler eg. `aws-loki-dev-ruler`>
admin: <Your AWS bucket for admin eg. `aws-loki-dev-admin`>
chunks: <Your AWS bucket for chunk, for example, `aws-loki-dev-chunk`>
ruler: <Your AWS bucket for ruler, for example, `aws-loki-dev-ruler`>
admin: <Your AWS bucket for admin, for example, `aws-loki-dev-admin`>
s3:
# s3 URL can be used to specify the endpoint, access key, secret key, and bucket name this works well for S3 compatible storages or are hosting Loki on-premises and want to use S3 as the storage backend. Either use the s3 URL or the individual fields below (AWS endpoint, region, secret).
s3: s3://access_key:secret_access_key@custom_endpoint/bucket_name
Expand Down Expand Up @@ -402,7 +402,7 @@ bloomGateway:



To configure other storage providers, refer to the [Helm Chart Reference]({{< relref "../reference" >}}).
To configure other storage providers, refer to the [Helm Chart Reference](https://grafana.com/docs/loki/<LOKI_VERSION>/setup/install/helm/reference/).

## Deploying the Loki Helm chart to a Production Environment

Expand All @@ -411,7 +411,7 @@ We are actively working on providing more guides for deploying Loki in productio
{{< /admonition >}}

It is recommended to run Loki at scale within in a cloud environment like AWS, Azure, or GCP. The below guides will show you how to deploy a minimally viable production environment.
- [Deploy Loki on AWS]({{< relref "../deployment-guides/aws" >}})
- [Deploy Loki on AWS](https://grafana.com/docs/loki/<LOKI_VERSION>/setup/install/helm/deployment-guides/aws)


## Next Steps
Expand Down
14 changes: 7 additions & 7 deletions docs/sources/setup/install/helm/install-scalable/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The default Helm chart deploys the following components:
- Index and Chunk cache (1 replica)

{{< admonition type="note" >}}
We do not recommended to run scalable mode with `filesystem` storage. For the purpose of this guide, we will use MinIO as the object storage to provide a complete example.
We do not recommended running scalable mode with `filesystem` storage. For the purpose of this guide, we will use MinIO as the object storage to provide a complete example.
{{< /admonition >}}

## Prerequisites
Expand Down Expand Up @@ -56,7 +56,7 @@ The following steps show how to deploy the Loki Helm chart in simple scalable mo
loki:
schemaConfig:
configs:
- from: 2024-04-01
- from: "2024-04-01"
store: tsdb
object_store: s3
schema: v13
Expand Down Expand Up @@ -130,8 +130,8 @@ loki:
period: 24h
storage_config:
aws:
region: <AWS region your bucket is in eg. `eu-west-2`>
bucketnames: <Your AWS bucket for chunk eg. `aws-loki-dev-chunk`>
region: <AWS region your bucket is in, for example, `eu-west-2`>
bucketnames: <Your AWS bucket for chunk, for example, `aws-loki-dev-chunk`>
s3forcepathstyle: false
pattern_ingester:
enabled: true
Expand All @@ -145,9 +145,9 @@ loki:
storage:
type: s3
bucketNames:
chunks: <Your AWS bucket for chunk eg. `aws-loki-dev-chunk`>
ruler: <Your AWS bucket for ruler eg. `aws-loki-dev-ruler`>
admin: <Your AWS bucket for admin eg. `aws-loki-dev-admin`>
chunks: <Your AWS bucket for chunk, for example, `aws-loki-dev-chunk`>
ruler: <Your AWS bucket for ruler, for example, `aws-loki-dev-ruler`>
admin: <Your AWS bucket for admin, for example, `aws-loki-dev-admin`>
s3:
# s3 URL can be used to specify the endpoint, access key, secret key, and bucket name this works well for S3 compatible storages or if you are hosting Loki on-premises and want to use S3 as the storage backend. Either use the s3 URL or the individual fields below (AWS endpoint, region, secret).
s3: s3://access_key:secret_access_key@custom_endpoint/bucket_name
Expand Down

0 comments on commit 905551b

Please sign in to comment.