Skip to content

Commit

Permalink
chore: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
  • Loading branch information
chaudum committed Oct 3, 2024
1 parent 0c038e5 commit 4344ec1
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions pkg/bloomgateway/client_pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,7 @@ func (p *JumpHashClientPool) Addr(key string) (string, error) {
}

func (p *JumpHashClientPool) updateLoop(_ context.Context) error {
servers := p.provider.Addresses()
// ServerList deterministically maps keys to _index_ of the server list.
// Since DNS returns records in different order each time, we sort to
// guarantee best possible match between nodes.
sort.Strings(servers)
err := p.SetServers(servers...)
err := p.SetServers(p.provider.Addresses()...)
if err != nil {
level.Warn(p.logger).Log("msg", "error updating servers", "err", err)
}
Expand Down

0 comments on commit 4344ec1

Please sign in to comment.