Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version in binary build info #172

Closed
trevorwhitney opened this issue Jan 17, 2025 · 3 comments
Closed

Fix version in binary build info #172

trevorwhitney opened this issue Jan 17, 2025 · 3 comments
Assignees

Comments

@trevorwhitney
Copy link
Collaborator

This has been reported in the loki repo

When building the binary artifacts that we upload to the cloud, and attach to a release once published (ie. the PR is merged), we are supposed to be providing the correct version that will be release in the build info when building the binaries. This used to work, but something broke with 3.3.0. It's using the k version for the weekly branch it was built from, meaning it's using the default IMAGE_TAG from the ./tools/image-tag` script.

@chaudum
Copy link
Contributor

chaudum commented Jan 24, 2025

@DylanGuedes @trevorwhitney Did this ever work?
grafana/loki#15939

@paul1r
Copy link
Contributor

paul1r commented Feb 10, 2025

grafana/loki#16159

@paul1r
Copy link
Contributor

paul1r commented Feb 10, 2025

grafana/loki#16169 for 3.3.x

@paul1r paul1r closed this as completed Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants