Ad hoc variables: add support for detected_field/.../values #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think one way to degrade gracefully will be to catch the error and resolve to an empty array, so we avoid this:
|
…6/detected-field-values
3 tasks
|
Looking soon. |
matyax
reviewed
Oct 31, 2024
matyax
reviewed
Oct 31, 2024
matyax
approved these changes
Oct 31, 2024
…6/detected-field-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for new detected_field/.../values endpoint in Loki 3.3.0 and Grafana 11.4 with graceful fallback support for older versions of both. Functionality should remain unchanged if the required versions are not met, so we should be able to release this safely before the dependencies.
Requires Grafana 11.4:
Requires Loki 3.3.0: