Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the golang version in the brew recipe #2699

Closed
mstoykov opened this issue Sep 28, 2022 · 2 comments
Closed

Pin the golang version in the brew recipe #2699

mstoykov opened this issue Sep 28, 2022 · 2 comments
Labels
ci evaluation needed proposal needs to be validated or tested before fully implementing it in k6

Comments

@mstoykov
Copy link
Contributor

Currently, the brew recipe just builds k6 with the latest go in brew.

We in generally do not update the go version exactly after it comes out as it usually has performance changes and sometimes even small brekaing changes for us(usually in tests).

In the past we also had had a couple of cases of changes in having significant changes on how k6 operates so it's not always just "bump the version" kind of change.

Every other official package has the version pinned except brew which makes little to no senses and makes thigns such as #2474 (comment) harder to diagnose for users.

While we can't do anything about every non official package we can at least make it work for the ones we control.

@mstoykov mstoykov added ci evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Sep 28, 2022
@mstoykov mstoykov added this to the v0.41.0 milestone Sep 28, 2022
@na--
Copy link
Member

na-- commented Sep 28, 2022

👍 , but I am not sure something like that will be accepted or if it's even possible. Generally, if they can, I think package maintainers try to use only a single compiler version for all packages with the same language in their repository 🤔

@na-- na-- modified the milestones: v0.41.0, TBD Oct 28, 2022
@codebien codebien removed this from the TBD milestone Sep 27, 2023
@mstoykov
Copy link
Contributor Author

I tried to get this to happen and while the homebrew formula language allows this, the project as a whole is against:

  1. pinning to dependancies , unless newer versions actually break it
  2. building from binaries

Given this I guess we will cross our fingers and point to that PR if anyone ever hits this again.

@mstoykov mstoykov closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci evaluation needed proposal needs to be validated or tested before fully implementing it in k6
Projects
None yet
Development

No branches or pull requests

3 participants