Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github exporter: github_repo_release_downloads is absent most of the time #236

Open
532910 opened this issue Feb 22, 2024 · 6 comments
Open
Labels
bug Something isn't working

Comments

@532910
Copy link

532910 commented Feb 22, 2024

What's wrong?

githubexporter/github-exporter#52

no github_repo_release_downloads metric is provided

Steps to reproduce

configure github exporter as described in documentation: https://grafana.com/docs/agent/latest/flow/reference/components/prometheus.exporter.github/

System information

No response

Software version

grafana-agent-flow 0.39.2-1

Configuration

No response

Logs

No response

@532910 532910 added the bug Something isn't working label Feb 22, 2024
@tpaschalis
Copy link
Member

Note: If this is indeed a bug with the upstream exporter (I haven't really looked at it yet), we'll have to fix it there first.

@hainenber
Copy link
Contributor

It appears that GH's rate limiter got into action. I'm not sure on its aggression though. Maybe expired/invalid API token?

This is coming from my local machine trying to reproduce the issue.

The config is

prometheus.exporter.github "example" {
  repositories   = ["grafana/agent"]
  api_token      = "REDACTED"
}

// Configure a prometheus.scrape component to collect github metrics.
prometheus.scrape "demo" {
  targets    = prometheus.exporter.github.example.targets
  forward_to = [prometheus.remote_write.demo.receiver]
}

prometheus.remote_write "demo" {
  endpoint {
    url = "localhost:8428"
  }
}
image

@532910
Copy link
Author

532910 commented Mar 1, 2024

It appears that GH's rate limiter got into action. I'm not sure on its aggression though. Maybe expired/invalid API token?

This is not true: only one repo of several doesn't provide github_repo_release_downloads

prometheus.exporter.github "default" {
  api_token_file = "/etc/grafana-agent-github-token"
  organizations = [ "nspcc-dev" ]
  repositories = [
    "nspcc-dev/neo-go",
    "nspcc-dev/neofs-node",
    "nspcc-dev/neofs-rest-gw",
    "nspcc-dev/neofs-s3-gw",
    "nspcc-dev/neo-exporter",
   ]
}

group by (repo) (github_repo_release_downloads) gives:

{repo="neo-exporter"} 1
{repo="neo-go"} 1
{repo="neofs-rest-gw"} 1
{repo="neofs-s3-gw"} 1

Copy link
Contributor

github-actions bot commented Apr 3, 2024

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@532910
Copy link
Author

532910 commented Apr 3, 2024

needs-attention

@rfratto
Copy link
Member

rfratto commented Apr 11, 2024

Hi there 👋

On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025.

To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :)

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants