Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ESLint to use new configs #514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Update ESLint to use new configs #514

wants to merge 1 commit into from

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented Jan 14, 2025

This removes warnings/errors when running ./build on a clean clone. ESLint migrated to using eslint.config.[js] files: https://eslint.org/docs/latest/use/configure/migration-guide.

This PR runs the migration script and fixes warnings associated. This was likely missed in a dependabot upgrade. See PR comments for more details.


This removes warnings/errors when running `./build` on a clean clone.
ESLint migrated to using `eslint.config.[js]` files:
https://eslint.org/docs/latest/use/configure/migration-guide.

This PR runs the migration script and fixes warnings associated. This
was likely missed in a dependabot upgrade. See PR comments for more
details.

---------

Co-authored-by: Daz DeBoer <daz@gradle.com>
@bigdaz bigdaz changed the title chore: Update ESLint to use new configs (#504) chore: Update ESLint to use new configs Jan 14, 2025
@bigdaz
Copy link
Member Author

bigdaz commented Jan 14, 2025

@Nava2 This PR is a squashed version of #504 with conflicts resolved. However, something in the configuration is causing lint to ignore violations.

@Nava2
Copy link
Contributor

Nava2 commented Jan 14, 2025

@Nava2 This PR is a squashed version of #504 with conflicts resolved. However, something in the configuration is causing lint to ignore violations.

Sounds good, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants