Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add gRPC GAPIC layer for Storage V1 #270

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feature: add gRPC GAPIC layer for Storage V1 #270

wants to merge 7 commits into from

Conversation

crwilcox
Copy link
Contributor

#269 asked about publishing the grpc proto surface. This PR adds gapic bazel generation of storage_v1

marking as do not merge for now but could be installed with pip install git+https://github.com/googleapis/python-storage@gapic-generation

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@vnghia vnghia mentioned this pull request Sep 15, 2020
Merged
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 15, 2020
@crwilcox crwilcox changed the title feature: add gRPC GAPIC Layer for Storage V1 feature: add gRPC GAPIC layer for Storage V1 Sep 15, 2020
@tseaver
Copy link
Contributor

tseaver commented Sep 23, 2020

The lint session fails with:

nox > black --check docs google tests noxfile.py setup.py
would reformat /tmpfs/src/github/python-storage/docs/conf.py
would reformat /tmpfs/src/github/python-storage/noxfile.py

crwilcox
crwilcox commented Sep 24, 2020
View reviewed changes
setup.py
@@ -32,6 +32,10 @@
"google-auth >= 1.11.0, < 2.0dev",
"google-cloud-core >= 1.4.1, < 2.0dev",
"google-resumable-media >= 1.0.0, < 2.0dev",
"google-api-core[grpc] >= 1.21.0, < 2.0.0dev",
"grpc-google-iam-v1 >= 0.12.3",
"proto-plus >= 1.3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these dependencies are python3+. We could add this and conditionally install, though possibly best to hold this pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankyn to figure out how to move this PR forward along.

@crwilcox crwilcox added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 24, 2020
@vnghia vnghia mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crwilcox @tseaver