feat: Add typed error classes #488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazuma
reviewed
Aug 13, 2024
There was a problem hiding this comment.
This looks great, and I think we'll likely take it, possibly with a tweak or two. However, we're just now in the middle of figuring out some new requirements related to exceptions/error reporting, so I'm going to hold on it for a few days while we check that things are aligned.
Use typed error classes so errors can be caught and handled in a more granular way.
blowmage
force-pushed
the
feature/typed-errors
branch
from
f8c3754
to
f423618
Compare
|
No problem on the wait. I appreciate your openness to accept the change. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use typed error classes so errors can be caught and handled in a more granular way.