fix: Handle 404 Status Code from MDS Identity Token calls #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1409
This changes makes the ID Token MDS call match the behavior of the three other MDS calls (Universe Domain, Access Token, and Service Account).
This will check for the additional error scenario (404 Not Found) in addition to the 503 (Unavailable). Perhaps other non 2xx status codes should be checked? For this PR, limit to just those two unless issues are raised.
Added tests for 404 + 503 for ID token. A larger refactoring effort outside of this PR can be made to add tests for the other three MDS calls (#1637).