-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make derived classes of CredentialSource public #1236
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
781fb65
to
4c6838e
Compare
Please move those classes into separate classes. Nested classes could cause bogus error in the future like we had recently. Once public it would be harder to move them out. @lsirac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move nested classes as separate if they become public
References to previous problems with nested imports: caused by: |
ebc48ac
to
14e5a78
Compare
oauth2_http/java/com/google/auth/oauth2/AwsCredentialSource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but seems like we need to keep an old base CredentialSource class for now, until the next major bump.
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nnotations to v1.1.1 (googleapis#1253) Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Currently credential source cannot be specified during initialization for AwsCredentials, IdentityPoolCredentials and PluggableAuthCredentials.
The corresponding derived credential sources have been made public for credential creation using credential sources.