Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: targeting API 35, the sample doesn't work properly, and the SDK's ad-inspector doesn't show the bottom UI properly either #783

Open
AndroidDeveloperLB opened this issue Dec 24, 2024 · 4 comments

Comments

@AndroidDeveloperLB
Copy link

Steps:

  1. Update the targetAPI to 35 on the sample "NativeAdvancedExample".
  2. Run on Android 15.
  3. Notice something weird at the top, and also check the ad-inspector.

The ad of the sample doesn't show properly , and for the ad-inspector, it doesn't let me reach the bottom properly. Can't press on the buttons there as they are being cut and hidden. Even for "send feedback" I get the same issue, as I can't see the EditText while typing, and there is no "next"/"send" button there.

image

Really guys, API 35 was published a long time ago. Admob should be one of the first ones to handle it properly...

Also reported here:
https://groups.google.com/g/google-admob-ads-sdk/c/ySMRrlVOfTs

Attached files:

NativeAdvancedExample.zip

@AndroidDeveloperLB
Copy link
Author

AndroidDeveloperLB commented Dec 24, 2024

I've found a workaround: replace the theme of AdActivity that is responsible of ad-inspector, to avoid edge-to-edge, as possible via this:

https://www.androidauthority.com/android-15-edge-to-edge-opt-out-3467646/#:~:text=The%20API%20in,window%20in%20question.

Meaning to add this to manifest:

<activity
    android:name="com.google.android.gms.ads.AdActivity" android:exported="false" android:theme="@style/AdInspectorActivityTheme"
    tools:replace="android:theme" />

and this to themes.xml:

<style name="AdInspectorActivityTheme" parent="@android:style/Theme.Translucent">
    <item name="android:windowOptOutEdgeToEdgeEnforcement" tools:targetApi="35">true</item>
</style>

It seems it also affects full-screen ads, such as rewarded-ads. I got this, as I have Pixel 6 which has the annoying display-cut of the camera hole:

image

Weird thing is that the bottom doesn't fit well.

For comparison, this is what I got when not using the workaround:

image

So both of these should be fixed.

@1nikolas
Copy link

1nikolas commented Jan 7, 2025

I try to get them to fix it here
https://groups.google.com/g/google-admob-ads-sdk/c/WyGsRV--EoE
This is the only place where you get to talk with actual google devs lol

The most important issue with all this is the interstitial ads where if you have navigation buttons enabled on landscape it obscures the ad close button and you can never click it...

@AndroidDeveloperLB
Copy link
Author

@1nikolas Did you try to use my workaround? Maybe will help here too.

@1nikolas
Copy link

1nikolas commented Jan 7, 2025

@1nikolas Did you try to use my workaround? Maybe will help here too.

No I'm just trying to make them fix it properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants