Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Compose Ads with JetAds #756

Open
pen-drive opened this issue Oct 2, 2024 · 2 comments
Open

Jetpack Compose Ads with JetAds #756

pen-drive opened this issue Oct 2, 2024 · 2 comments
Assignees

Comments

@pen-drive
Copy link

I apologize for any inconvenience this may cause; this is not precisely an issue report. I am currently developing a library designed to simplify the implementation of ads in Jetpack Compose applications, called JetAds.

I would greatly appreciate your feedback on this library, particularly regarding its functionality and usability. The philosophy behind JetAds is "plug and earn," emphasizing ease of use. While I believe the core functionality is robust, there are certainly areas for improvement in how the library can be consumed.

Your insights would be invaluable in helping me enhance the library further.

@NVentimiglia
Copy link
Member

Did a quick look and I see two things off to top:

  • The BannerAd is loaded by the composable. This means that preloading and pooling solutions which require a separation of the adview and the composable are not possible. Also, Banner variations (Fixed / Adaptive) required their own composable and can not reuse a single banner composable. There is some layer friction here.
  • The Callbacks do not return a BannerAd when loaded, this means that publishers will not be able get a reference to the Ad for things such as ResponseInfo.

@NVentimiglia NVentimiglia self-assigned this Oct 2, 2024
@pen-drive
Copy link
Author

Thank you very much for the feedback, I will work on these corrections. Can I keep in touch here if I have any questions during the development of the library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants