Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/targets: change the default DataOffset value #5742

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

a-nogikh
Copy link
Collaborator

@a-nogikh a-nogikh commented Feb 4, 2025

The current default value sometimes intersects with the addresses used by malloc, which causes executor memory corruptions.

Closes #5674.

ramosian-glider
ramosian-glider previously approved these changes Feb 4, 2025
Copy link
Member

@ramosian-glider ramosian-glider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@a-nogikh
Copy link
Collaborator Author

a-nogikh commented Feb 4, 2025

Error: cyclomatic complexity 25 of func `initTarget` is high (> 24) (gocyclo)`

The current default value sometimes intersects with the addresses used
by malloc, which causes executor memory corruptions.

Closes google#5674.
@a-nogikh a-nogikh added this pull request to the merge queue Feb 4, 2025
Merged via the queue into google:master with commit f1930ee Feb 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/fuzzer: occasional TestFuzz failures
3 participants