Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove more mentions of the vendor folder #5699

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

a-nogikh
Copy link
Collaborator

The one remaining mention is this:

This was manually vendored on the version v2.0.8
(which matches the compiler version in the env container)
using the following commands:
git clone --branch=v2.0.8 --depth=1 --single-branch https://github.com/google/flatbuffers.git
cp flatbuffers/LICENSE.txt syzkaller/vendor/flatbuffers/
cp flatbuffers/include/flatbuffers/*.h syzkaller/vendor/flatbuffers/

Is that still relevant?

@a-nogikh a-nogikh requested a review from dvyukov January 23, 2025 13:13
@a-nogikh a-nogikh mentioned this pull request Jan 23, 2025
2 tasks
dvyukov
dvyukov previously approved these changes Jan 23, 2025
@dvyukov
Copy link
Collaborator

dvyukov commented Jan 23, 2025

The one remaining mention is this:

This was manually vendored on the version v2.0.8
(which matches the compiler version in the env container)
using the following commands:
git clone --branch=v2.0.8 --depth=1 --single-branch https://github.com/google/flatbuffers.git
cp flatbuffers/LICENSE.txt syzkaller/vendor/flatbuffers/
cp flatbuffers/include/flatbuffers/*.h syzkaller/vendor/flatbuffers/

Is that still relevant?

It's left-over from 9d9141e

We need to update the comment rather than remove it.

@a-nogikh
Copy link
Collaborator Author

Cc @tarasmadan

@a-nogikh
Copy link
Collaborator Author

Updated the README. PTAL.

@a-nogikh a-nogikh enabled auto-merge January 23, 2025 16:26
@a-nogikh a-nogikh added this pull request to the merge queue Jan 23, 2025
Merged via the queue into google:master with commit 521b0ce Jan 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants