Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/syz-diff: move the logic to pkg/manager #5697

Merged
merged 3 commits into from
Jan 23, 2025
Merged

tools/syz-diff: move the logic to pkg/manager #5697

merged 3 commits into from
Jan 23, 2025

Conversation

a-nogikh
Copy link
Collaborator

  • Refactor the code to shut down gracefully on context cancellation.
  • Replace some of log.Fatalf calls with errors.
  • Move the core of syz-diff code to pkg/manager to faciltiate reuse.

@a-nogikh
pkg/manager: accept context in the HTTP server
9785fc5 
It enables stopping the server.
Also, replace some log.Fatalf calls by returning errors.
@a-nogikh
tools/syz-diff: prepare for moving to pkg/
b604ccb 
Adjust the code to properly handle context cancellation.
Replace log.Fatalf() by errors where it was straightforward.
Decouple from the global variables.
@a-nogikh
tools/syz-diff: move the logic to pkg/manager
494efe3
@a-nogikh a-nogikh requested a review from dvyukov January 23, 2025 11:02
@a-nogikh a-nogikh added this pull request to the merge queue Jan 23, 2025
Merged via the queue into google:master with commit f6a35ef Jan 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvyukov dvyukov dvyukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-nogikh @dvyukov