dashboard/app: show manager unique coverage #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarasmadan
changed the title
tarasmadan
force-pushed
the
only_manager
branch
12 times, most recently
from
b7ab60c to
bd4430f
Compare
tarasmadan
changed the title
tarasmadan
force-pushed
the
only_manager
branch
from
bd4430f to
a6c27df
Compare
tarasmadan
force-pushed
the
only_manager
branch
from
a6c27df to
7c7792d
Compare
tarasmadan
changed the title
tarasmadan
force-pushed
the
only_manager
branch
8 times, most recently
from
a3e20fd to
e55a2da
Compare
tarasmadan
force-pushed
the
only_manager
branch
4 times, most recently
from
bbd06db to
2800c35
Compare
tarasmadan
changed the title
tarasmadan
force-pushed
the
only_manager
branch
2 times, most recently
from
4a7efa0 to
4ff6c0f
Compare
|
@dvyukov PTAL |
tarasmadan
force-pushed
the
only_manager
branch
9 times, most recently
from
7391ee1 to
aab044d
Compare
1. Make heatmap testable, move out the spanner client instantiation. 2. Generate spannerdb.ReadOnlyTransaction mocks. 3. Generate spannerdb.RowIterator mocks. 4. Generate spannerdb.Row mocks. 5. Prepare spannerdb fixture. 6. Fixed html control name + value. 7. Added multiple tests. 8. Show line coverage from selected manager. 9. Propagate coverage url params to file coverage url.
1. Init coveragedb client once and propagate it through context to enable mocking. 2. Always init coverage handlers. It simplifies testing. 3. Read webGit and coveragedb client from ctx to make it mockable. 4. Use int for file line number and int64 for merged coverage. 5. Add tests.
tarasmadan
force-pushed
the
only_manager
branch
from
aab044d to
7ee1f67
Compare
dvyukov
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to see unique coverage from selected manager.
To get unique coverage, I'm getting 2 data streams from spanner.
First - selected manager data, second - data from all managers.
Fetched data includes line coverage information which is quite expensive.
If some file line was visited 10 times in total and from the specific manager, this line is counted as a unique coverage.
TODO: