From c3c11697578256f00c7e18b274ff821f0ffc6e28 Mon Sep 17 00:00:00 2001
From: Taras Madan <tarasmadan@google.com>
Date: Thu, 6 Feb 2025 11:01:02 +0100
Subject: [PATCH] all: fix html warnings

Wrong closing tags etc.
---
 dashboard/app/templates/admin.html     | 2 +-
 dashboard/app/templates/manager.html   | 2 +-
 dashboard/app/templates/templates.html | 4 ++--
 pkg/manager/html/common.html           | 4 ++--
 pkg/manager/html/crash.html            | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/dashboard/app/templates/admin.html b/dashboard/app/templates/admin.html
index dddc03d46720..7bf3f2fea305 100644
--- a/dashboard/app/templates/admin.html
+++ b/dashboard/app/templates/admin.html
@@ -46,7 +46,7 @@
 			<td class="stat">{{.Items}}</td>
 			<td class="stat">{{.Bytes}}</td>
 			<td class="stat">{{.Oldest}}</td>
-			<td><a href="?action=memcache_flush">flush</input></td>
+			<td><a href="?action=memcache_flush">flush</a></td>
 		</tr>
 	</table>
 	{{end}}
diff --git a/dashboard/app/templates/manager.html b/dashboard/app/templates/manager.html
index 65c3d9cb7d04..3f9d190b061d 100644
--- a/dashboard/app/templates/manager.html
+++ b/dashboard/app/templates/manager.html
@@ -26,7 +26,7 @@
 					<span class="input-group">
 					<textarea name="send-repro"></textarea>
 					</span>
-					<input type="submit" name="show-crashers" value="Submit"></div>
+					<input type="submit" name="show-crashers" value="Submit">
 				</form>
 			</div>
 		</div>
diff --git a/dashboard/app/templates/templates.html b/dashboard/app/templates/templates.html
index bcf1551fa064..571e262cdfb3 100644
--- a/dashboard/app/templates/templates.html
+++ b/dashboard/app/templates/templates.html
@@ -535,9 +535,9 @@ <h1><a href="/{{$.Namespace}}">syzbot</a></h1>
 						{{optlink $job.CrashLogLink "log"}}
 					{{end}}
 					{{ if $job.InvalidatedBy }}
-						</br>marked invalid by {{$job.InvalidatedBy}}
+						<br>marked invalid by {{$job.InvalidatedBy}}
 					{{end}}
-					{{if and $.PerBug (or .InvalidateJobLink .RestartJobLink)}}<br/>{{optlink .RestartJobLink "🔄 retry this bisection"}}&nbsp;&nbsp;{{optlink .InvalidateJobLink "❌ mark as invalid"}}{{end}}
+					{{if and $.PerBug (or .InvalidateJobLink .RestartJobLink)}}<br>{{optlink .RestartJobLink "🔄 retry this bisection"}}&nbsp;&nbsp;{{optlink .InvalidateJobLink "❌ mark as invalid"}}{{end}}
 				</td>
 			</tr>
 		{{end}}
diff --git a/pkg/manager/html/common.html b/pkg/manager/html/common.html
index ea76b5a634cb..1a6d1c0efb8b 100644
--- a/pkg/manager/html/common.html
+++ b/pkg/manager/html/common.html
@@ -21,10 +21,10 @@ <h1><a href="/">syzkaller</a></h1>
 						<input type="hidden" name="url" value="{{.CurrentURL}}" />
 						<button type="submit" name="toggle" value="expert" class="action_button{{if .ExpertMode}}_selected{{end}}" title="Toggle expert mode">
 							🧠
-						</input>
+						</button>
 						<button type="submit" name="toggle" value="pause" class="action_button{{if .Paused}}_selected{{end}}" title="Pause/unpause fuzzing">
 							{{if .Paused}}▶️{{else}}⏸️{{end}}
-						</input>
+						</button>
 					</form>
 				</td>
 				<td class="search">
diff --git a/pkg/manager/html/crash.html b/pkg/manager/html/crash.html
index 6554f2817fb7..48c50ab71aca 100644
--- a/pkg/manager/html/crash.html
+++ b/pkg/manager/html/crash.html
@@ -23,7 +23,7 @@
 		<td><a href="/file?name={{$c.Log}}">log</a></td>
 		<td>
 			{{if $c.Report}}
-				<a href="/file?name={{$c.Report}}">report</a></td>
+				<a href="/file?name={{$c.Report}}">report</a>
 			{{end}}
 		</td>
 		<td class="time {{if not $c.Active}}inactive{{end}}">{{formatTime $c.Time}}</td>