fix(importer): tolerate blobs disappearing #2679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed some errors getting logged by the GCS deletion code because the blob disappeared in between the bucket getting listed and the blobs being retrieved (this can happen, but led me to also find the fix in Also give validation failure the same exception-raising treatment as the refactor in google#2644 did for import-time validation failure.
oliverchang
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some errors getting logged by the GCS deletion code because the blob disappeared in between the bucket getting listed and the blobs being retrieved (this can happen, but led me to also find the fix in #2678
Also give validation failure the same exception-raising treatment as the refactor in #2644 did for import-time validation failure.