refactor(importer): extract inline GCS parsing function #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding schema validation failure reporting, revisit the outstanding TODO to refactor the inline `convert_blob_to_vuln()` function inside of `process_updates_bucket()` Make related unit tests more user-friendly
oliverchang
reviewed
Sep 23, 2024
Reviewer confirmed this is WAI and I reflected this in the docstring
oliverchang
approved these changes
Sep 24, 2024
another-rex
reviewed
Sep 25, 2024
Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
Wired: Being able to directly suggest changes via the GitHub review interface Tired: Having them not be linter-compliant :-(
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
Sep 30, 2024
I noticed some errors getting logged by the GCS deletion code because the blob disappeared in between the bucket getting listed and the blobs being retrieved (this can happen, but led me to also find the fix in Also give validation failure the same exception-raising treatment as the refactor in google#2644 did for import-time validation failure.
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
Oct 1, 2024
This reverts commit 447a30c. There is a suspected unknown performance regression.
andrewpollock
added a commit
that referenced
this pull request
Oct 1, 2024
andrewpollock
added a commit
to andrewpollock/osv.dev
that referenced
this pull request
Oct 1, 2024
This reverts commit 165b2fe. Fix performance regression introduced: - don't create a new storage client and Data Store client for each thread processing a GCS blob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding schema validation failure reporting, revisit the outstanding TODO to refactor the inline
convert_blob_to_vuln()function inside ofprocess_updates_bucket()from when the GCS record deletion code was added.Make related unit tests more user-friendly