Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Maven registries in OSV entries #2088

Open
oliverchang opened this issue Apr 4, 2024 · 2 comments
Open

Support Maven registries in OSV entries #2088

oliverchang opened this issue Apr 4, 2024 · 2 comments
Labels
backlog Important but currently unprioritized enhancement New feature or request

Comments

@oliverchang
Copy link
Collaborator

ossf/osv-schema#231 was just merged, which adds optional Maven registries to the Maven ecosystem:

i.e.

      "package": {
        "ecosystem": "Maven:https://mycoolregistry.com",
        "name": "io.netty:netty-handler"
      },

There are some additional considerations to be made here for our matching logic:

The default assumed registry is https://repo.maven.apache.org/maven2 (and perhaps other common variants/mirrors?). API queries must take this into account, with {"ecosystem": "Maven"} and {"ecosystem": "Maven:https://repo.maven.apache.org/maven2"} both matching against OSV entries with either formatting. We may want to just normalize Maven ecosystems on ingestion to strip the Maven central URL if it is provided.

Unlike with other Linux distros queries, where {"ecosystem": "Debian"} matches against OSV entries with {"ecosystem": "Debian:<anything>"}, API queries specifying {"ecosystem": "Maven"} should not match against all registries. It should default to Maven Central per above.

@oliverchang oliverchang added the enhancement New feature or request label Apr 4, 2024
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jul 18, 2024
@andrewpollock andrewpollock added the backlog Important but currently unprioritized label Jul 23, 2024
@oliverchang oliverchang removed the backlog Important but currently unprioritized label Jul 29, 2024
@github-actions github-actions bot removed the stale The issue or PR is stale and pending automated closure label Jul 30, 2024
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

See https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md for how to contribute a PR if you're interested in helping out.

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Sep 28, 2024
@oliverchang oliverchang added backlog Important but currently unprioritized and removed stale The issue or PR is stale and pending automated closure labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Important but currently unprioritized enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants