Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEMVER version advisories appearing for ecosystems with non-semver versions #1834

Open
another-rex opened this issue Nov 27, 2023 · 3 comments
Labels
backlog Important but currently unprioritized bug Something isn't working

Comments

@another-rex
Copy link
Contributor

Describe the bug
https://osv.dev/vulnerability/MAL-2023-8369 is an example of a SEMVER affected version range in PyPI, which is not a SemVer version.

To Reproduce
Try to query the telethon2 package with any version and it will not return that advisory

Expected behaviour
The advisory to be returned

Additional context
For malicious packages specifically, they generally get removed from the repositories, so we can't enumerate versions. We need some sort of wildcard version that matches all versions, for non-semver ecosystems.

@another-rex another-rex added the bug Something isn't working label Nov 27, 2023
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Jul 20, 2024
@andrewpollock andrewpollock added the backlog Important but currently unprioritized label Jul 23, 2024
@andrewpollock
Copy link
Contributor

andrewpollock commented Jul 26, 2024

We had shades of this problem recently with the Bitnami ecosystem in bitnami/vulndb#336, because it's also essentially an "aggregator" from multiple ecosystems with disparate versioning schemes. If I recall correctly, they managed to successfully converge on SEMVER for all of their versioning.

Once #2401 is complete, this ecosystem could presumably just express ranges as ECOSYSTEM where necessary/appropriate and they wouldn't need to be coerced to SEMVER at import time?

/cc @calebbrown

@oliverchang oliverchang removed the backlog Important but currently unprioritized label Jul 29, 2024
@github-actions github-actions bot removed the stale The issue or PR is stale and pending automated closure label Jul 30, 2024
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

See https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md for how to contribute a PR if you're interested in helping out.

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Sep 28, 2024
@oliverchang oliverchang added backlog Important but currently unprioritized and removed stale The issue or PR is stale and pending automated closure labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Important but currently unprioritized bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants