Skip to content

Commit

Permalink
Fix misused glob in BUILD.qt_win.bazel (#1151)
Browse files Browse the repository at this point in the history
This follows up to my previous commit [1], which aimed to enable us to
use Bazel to build executables with Qt6 dependencies.

Thanks to '--incompatible_disallow_empty_glob', which is going to be
enabled by default from Bazel 8.0, it is clear that an empty list was
set to 'hdrs' despite my intention. Let's fix it (#1150).

There must be no change in the final artifacts.

 [1]: 019911b

PiperOrigin-RevId: 709014821
  • Loading branch information
yukawa authored Dec 24, 2024
1 parent 99e45d3 commit 81d9aa7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/bazel/BUILD.qt_win.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ cc_library(
],
}),
hdrs = glob([
"include",
"include/QtCore/*",
"include/QtGui/*",
"include/QtWidgets/*",
]),
includes = [
"include",
Expand Down

0 comments on commit 81d9aa7

Please sign in to comment.