codecov fixed?

google · Jul 19, 2024 · 93f8c2d · 93f8c2d
1 parent 52272a4
commit 93f8c2d
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 24 deletions.
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
diff --git a/mono_repo/README.md b/mono_repo/README.md
@@ -148,6 +148,7 @@ coverage_service:
 # https://coveralls.io/ - the default
 - coveralls
 # https://codecov.io/ – the other option
+# NOTE: `CODECOV_TOKEN` must be populated in your GitHub actions secrets
 - codecov
 ```
 

diff --git a/mono_repo/lib/src/task_type.dart b/mono_repo/lib/src/task_type.dart
@@ -151,30 +151,31 @@ class _TestWithCoverageTask extends TaskType {
     String packageDirectory,
     BasicConfiguration config,
     RootConfig rootConfig,
-  ) {
+  ) sync* {
     final countString = (_count++).toString().padLeft(2, '0');
-    return [
-      if (config.coverageProcessors.contains(CoverageProcessor.coveralls))
-        ActionInfo.coveralls.usage(
-          name: 'Upload coverage to Coveralls',
-          withContent: {
-            // https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow
-            'github-token': r'${{ secrets.GITHUB_TOKEN }}',
-            'path-to-lcov': '$packageDirectory/coverage/lcov.info',
-            'flag-name': 'coverage_$countString',
-            'parallel': true,
-          },
-          versionOverrides: rootConfig.existingActionVersions,
-        ),
-      if (config.coverageProcessors.contains(CoverageProcessor.codecov))
-        ActionInfo.codecov.usage(
-          withContent: {
-            'files': '$packageDirectory/coverage/lcov.info',
-            'fail_ci_if_error': true,
-            'name': 'coverage_$countString',
-          },
-          versionOverrides: rootConfig.existingActionVersions,
-        ),
-    ];
+    if (config.coverageProcessors.contains(CoverageProcessor.coveralls)) {
+      yield ActionInfo.coveralls.usage(
+        name: 'Upload coverage to Coveralls',
+        withContent: {
+          // https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow
+          'github-token': r'${{ secrets.GITHUB_TOKEN }}',
+          'path-to-lcov': '$packageDirectory/coverage/lcov.info',
+          'flag-name': 'coverage_$countString',
+          'parallel': true,
+        },
+        versionOverrides: rootConfig.existingActionVersions,
+      );
+    }
+    if (config.coverageProcessors.contains(CoverageProcessor.codecov)) {
+      yield ActionInfo.codecov.usage(
+        withContent: {
+          'files': '$packageDirectory/coverage/lcov.info',
+          'fail_ci_if_error': true,
+          'name': 'coverage_$countString',
+          'token': r'${{ secrets.CODECOV_TOKEN }}'
+        },
+        versionOverrides: rootConfig.existingActionVersions,
+      );
+    }
   }
 }