Run scroll command via Angular afterRender hook #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwillchen
approved these changes
Jan 16, 2025
| console.error( | ||
| `Could not scroll to component with key ${this.commandScrollKey} because no component found`, | ||
| ); | ||
| return; |
There was a problem hiding this comment.
probably would be good to do this before the return:
this.commandScrollKey = '';
this branch is already an edge case, but having the command scroll key somehow run in a future render loop when the the target element exists, seems like an even more bizzare edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got a chance to test out the afterRender suggestion. It seems to work.
Closes #1121