Skip to content

Commit

Permalink
Move dev tools-related services into sub-package
Browse files Browse the repository at this point in the history
wwwillchen committed Nov 27, 2023
1 parent 42d464d commit 349433d
Showing 8 changed files with 27 additions and 10 deletions.
6 changes: 3 additions & 3 deletions web/src/app/app.ts
Original file line number Diff line number Diff line change
@@ -14,9 +14,9 @@ import { MatIconModule, MatIconRegistry } from "@angular/material/icon";
import { MatButtonModule } from "@angular/material/button";
import { MatSidenavModule } from "@angular/material/sidenav";
import { DevTools } from "../dev_tools/dev_tools";
import { DebugService } from "../services/debug_service";
import { Logger } from "../services/logger";
import { TypeDeserializer } from "../services/type_deserializer";
import { DebugService } from "../dev_tools/services/debug_service";
import { Logger } from "../dev_tools/services/logger";
import { TypeDeserializer } from "../dev_tools/services/type_deserializer";

@Component({
selector: "app",
2 changes: 1 addition & 1 deletion web/src/dev_tools/logs_panel/logs_panel.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Component } from "@angular/core";
import { Logger } from "../../services/logger";
import { Logger } from "../services/logger";
import { ObjectTree } from "../object_tree/object_tree";

@Component({
21 changes: 21 additions & 0 deletions web/src/dev_tools/services/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
load("//tools:defaults.bzl", "ng_module")

package(
default_visibility = ["//:optic_internal"],
)

ng_module(
name = "services",
srcs = glob([
"*.ts",
]),
deps = [
"//optic/components/box:box_ts_proto",
"//optic/components/button:button_ts_proto",
"//optic/components/checkbox:checkbox_ts_proto",
"//optic/components/text:text_ts_proto",
"//optic/components/text_input:text_input_ts_proto",
"//protos:ui_ts_proto",
"@npm//@angular/compiler",
],
)
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 1 addition & 5 deletions web/src/services/BUILD
Original file line number Diff line number Diff line change
@@ -10,12 +10,8 @@ ng_module(
"*.ts",
]),
deps = [
"//optic/components/box:box_ts_proto",
"//optic/components/button:button_ts_proto",
"//optic/components/checkbox:checkbox_ts_proto",
"//optic/components/text:text_ts_proto",
"//optic/components/text_input:text_input_ts_proto",
"//protos:ui_ts_proto",
"//web/src/dev_tools/services",
"@npm//@angular/compiler",
],
)
2 changes: 1 addition & 1 deletion web/src/services/channel.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Injectable, NgZone } from "@angular/core";
import * as pb from "optic/protos/ui_ts_proto_pb/protos/ui_pb";
import { Logger } from "./logger";
import { Logger } from "../dev_tools/services/logger";

const anyWindow = window as any;
const DEV_SERVER_HOST = anyWindow["OPTIC_SERVER_HOST"] || "";

0 comments on commit 349433d

Please sign in to comment.