Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove note about tuning only being supported for 1.0. #517

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Remove note about tuning only being supported for 1.0. #517

merged 1 commit into from
Sep 10, 2024

Conversation

pcoet
Copy link
Contributor

@pcoet pcoet commented Sep 10, 2024 •
edited
Loading

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@pcoet pcoet requested a review from a team as a code owner September 10, 2024 13:45
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Sep 10, 2024
lucianommartins
lucianommartins approved these changes Sep 10, 2024
View reviewed changes
Copy link

@lucianommartins lucianommartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcoet
Copy link
Contributor Author

pcoet commented Sep 10, 2024

@lucianommartins Thanks for the quick review!

@pcoet pcoet merged commit 52c33ff into main Sep 10, 2024
5 checks passed
@pcoet pcoet deleted the pcoet-patch-1 branch September 10, 2024 13:54
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianommartins lucianommartins lucianommartins approved these changes

Assignees
No one assigned
Labels
component:documentation Update docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcoet @lucianommartins