Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "revert oss_fuzz_corpus typo fix (#1997)" #1999

Merged
merged 4 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions docs/internal-documentation/service.md

This file was deleted.

30 changes: 0 additions & 30 deletions presubmit.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,10 @@
import sys
from typing import List, Optional

import yaml

from common import benchmark_utils
from common import fuzzer_utils
from common import filesystem
from common import logs
from common import yaml_utils
from service import automatic_run_experiment
from src_analysis import change_utils
from src_analysis import diff_utils

Expand Down Expand Up @@ -258,31 +254,6 @@ def yapf(paths: List[Path], validate: bool = True) -> bool:
return success


def validate_experiment_requests(paths: List[Path]):
"""Returns False if service/experiment-requests.yaml it is in |paths| and is
not valid."""
if Path(automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH) not in paths:
return True

try:
experiment_requests = yaml_utils.read(
automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH)
except yaml.parser.ParserError:
print('Error parsing '
f'{automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH}.')
return False

# Only validate the latest request.
result = automatic_run_experiment.validate_experiment_requests(
experiment_requests[:1])

if not result:
print(f'{automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH}'
'is not valid.')

return result


def is_path_ignored(path: Path) -> bool:
"""Returns True if |path| is a subpath of an ignored directory or is a
third_party directory."""
Expand Down Expand Up @@ -441,7 +412,6 @@ def main() -> int:
('typecheck', pytype),
('test', pytest),
('validate_fuzzers_and_benchmarks', validate_fuzzers_and_benchmarks),
('validate_experiment_requests', validate_experiment_requests),
('test_changed_integrations', test_changed_integrations),
]

Expand Down
Loading
Loading