Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and improve zh-TW Traditional Chinese locale #2158

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Update and improve zh-TW Traditional Chinese locale #2158

merged 2 commits into from
Jan 9, 2025

Conversation

PeterDaveHello
Copy link
Contributor

🎉

@chalin
Copy link
Collaborator

chalin commented Jan 9, 2025

@tico88612 @ydFu @hwchiu @johnlinp - might you be available to review this PR? Thank you in advance!

p.s. I found your GH handles in the CNCF Glossary repo CODEOWNERS file, https://github.com/cncf/glossary/blob/879b6c7ec2a0bb40a5592d1b90b8b1779e286bbb/CODEOWNERS#L77-L79

/cc @nate-double-u

tico88612
tico88612 reviewed Jan 9, 2025
View reviewed changes
Copy link

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

i18n/zh-tw.toml Outdated Show resolved Hide resolved
@PeterDaveHello @tico88612
Update i18n/zh-tw.toml with suggestion from @tico88612
c5239b1 
Co-authored-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@chalin
Copy link
Collaborator

chalin commented Jan 9, 2025 •
edited
Loading

@PeterDaveHello - thanks for your contribution. You'll need to sign the CLA before this can be merged.

Edit: oops, no @tico88612 can you sign the CLA? It is needed because your suggestion was accepted.

@PeterDaveHello
Copy link
Contributor Author

It looks like we need the CLA signed from @tico88612 😅

@tico88612
Copy link

tico88612 commented Jan 9, 2025 •
edited
Loading

The PR was blocked because I didn't pass CLA. (because I am using my GitHub private email.)

You can remove it or use my real email.

EDIT: tico88612 at gmail.com

@chalin
Copy link
Collaborator

chalin commented Jan 9, 2025

Thanks @tico88612, I'll see what I can do to address the CLA issue given that your other address passes the CLA check.

@tico88612 - can you officially approve the PR if you agree with the changes now? Thanks again.

tico88612
tico88612 approved these changes Jan 9, 2025
View reviewed changes
Copy link

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@chalin
Copy link
Collaborator

chalin commented Jan 9, 2025

Merging on @tico88612's review and approval and CLA/DCO via #2158 (comment).

@chalin chalin merged commit a9ea2b7 into google:main Jan 9, 2025
10 of 11 checks passed
@chalin
Copy link
Collaborator

chalin commented Jan 9, 2025

Thanks all! 🙌🏻

@PeterDaveHello PeterDaveHello deleted the zh-tw branch January 9, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterDaveHello @chalin @tico88612