Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add feedback_* to i18n/ja.toml #2149

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

rinsuki
Copy link
Contributor

@rinsuki rinsuki commented Dec 22, 2024

Context: while reading OpenTelemetry's document, I noticed that their feedback form's i18n is completely broken in Japanese:

image

(Screenshot of https://opentelemetry.io/ja/docs/ )

and after some research, I think it was from docsy, not opentelemetry.io's fault, then I just made this patch.

Copy link

google-cla bot commented Dec 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chalin chalin force-pushed the i18n/ja/feedback_strings branch from 7efa316 to 9db919f Compare January 3, 2025 22:05
@chalin
Copy link
Collaborator

chalin commented Jan 3, 2025

Thank you @rinsuki, I've asked https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers to review and comment.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will give OTel docs-ja-maintainers some time to give feedback.

@@ -77,3 +77,13 @@ other = "If you want to get more involved by contributing to {{ .Site.Title }},
other = "You can find out how to contribute to {{ .Site.Title }} in our"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that there are some more untranslated lines/strings in this file:

https://github.com/google/docsy/blob/fa81a86be8bf130d94a43b8898c6716819fdae87/i18n/ja.toml#L63C1-L79C34

@rinsuki: are you able to translate these lines as well? Your help is appreciated!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically I can directly translate word-by-word, but I think it wouldn't be a good translate (If I do that, japanese speakers (like me) feels it is translated from other language rather than written by native), but I don't have a idea to good paraphrase for its text right now.

by the way, community_how_to assume text ends with community_guideline:

<p>
{{ T "community_how_to" . }}
<a href="{{ $contribUrl | relURL }}">{{ T "community_guideline" }}</a>.
</p>

but some languages wants to have additional text after link, it would be good to have something like community_how_to_suffix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks @rinsuki. I'll merge this as an increment, and we can address the other fields as necessary. Thanks for pointing that out @deining.

@ymotongpoo
Copy link

@chalin Do you need Japanese speakers review? (it seems https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers consists of non-Japanese speakers. Asking just in case.)

If yes, the content looks good to me. (btw, https://github.com/orgs/open-telemetry/teams/docs-ja-approvers is docs-ja-maintainers + me and @katzchang)

@chalin
Copy link
Collaborator

chalin commented Jan 4, 2025

@chalin Do you need Japanese speakers review? (it seems https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers consists of non-Japanese speakers. Asking just in case.)

Oh! Yes, that was my intention.

If yes, the content looks good to me.

Thank you for validating.

(btw, https://github.com/orgs/open-telemetry/teams/docs-ja-approvers is docs-ja-maintainers + me and @katzchang)

Got it, thanks.

@chalin chalin merged commit 2f361b2 into google:main Jan 4, 2025
11 checks passed
@chalin chalin added this to the 25Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants