-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Add feedback_* to i18n/ja.toml #2149
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7efa316
to
9db919f
Compare
Thank you @rinsuki, I've asked https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers to review and comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will give OTel docs-ja-maintainers
some time to give feedback.
@@ -77,3 +77,13 @@ other = "If you want to get more involved by contributing to {{ .Site.Title }}, | |||
other = "You can find out how to contribute to {{ .Site.Title }} in our" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized that there are some more untranslated lines/strings in this file:
@rinsuki: are you able to translate these lines as well? Your help is appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically I can directly translate word-by-word, but I think it wouldn't be a good translate (If I do that, japanese speakers (like me) feels it is translated from other language rather than written by native), but I don't have a idea to good paraphrase for its text right now.
by the way, community_how_to
assume text ends with community_guideline
:
docsy/layouts/partials/community_links.html
Lines 18 to 21 in fa81a86
<p> | |
{{ T "community_how_to" . }} | |
<a href="{{ $contribUrl | relURL }}">{{ T "community_guideline" }}</a>. | |
</p> |
but some languages wants to have additional text after link, it would be good to have something like community_how_to_suffix
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chalin Do you need Japanese speakers review? (it seems https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers consists of non-Japanese speakers. Asking just in case.) If yes, the content looks good to me. (btw, https://github.com/orgs/open-telemetry/teams/docs-ja-approvers is |
Oh! Yes, that was my intention.
Thank you for validating.
Got it, thanks. |
Context: while reading OpenTelemetry's document, I noticed that their feedback form's i18n is completely broken in Japanese:
(Screenshot of https://opentelemetry.io/ja/docs/ )
and after some research, I think it was from docsy, not opentelemetry.io's fault, then I just made this patch.