Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user guide, definition listings of site params: add 'params' context #1828

Merged
merged 3 commits into from
Feb 3, 2024
Merged

user guide, definition listings of site params: add 'params' context #1828

merged 3 commits into from
Feb 3, 2024

Conversation

deining
Copy link
Collaborator

@deining deining commented Feb 3, 2024 •
edited by chalin
Loading

This is a follow up on #1771: following the suggestion mentioned in this comment, a full review of all definition listings of site params was performed and where needed, the params context was added.

@deining deining added enhancement New feature or request user guide Improvements to user guide labels Feb 3, 2024
@deining deining requested a review from chalin February 3, 2024 17:01
chalin
chalin reviewed Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the followup 👍🏻
See inline comments.

userguide/content/en/docs/get-started/basic-configuration.md Outdated Show resolved Hide resolved
userguide/content/en/docs/adding-content/content.md Outdated Show resolved Hide resolved
userguide/content/en/docs/adding-content/content.md Outdated Show resolved Hide resolved
@deining deining requested a review from chalin February 3, 2024 20:49
@deining
Copy link
Collaborator Author

deining commented Feb 3, 2024

Thanks for the prompt review. All raised issues are now resolved.

chalin
chalin reviewed Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment, thanks.

userguide/content/en/docs/get-started/basic-configuration.md Outdated Show resolved Hide resolved
chalin
chalin reviewed Feb 3, 2024
View reviewed changes
.hvm Outdated Show resolved Hide resolved
@deining deining requested a review from chalin February 3, 2024 21:52
chalin
chalin approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin
Copy link
Collaborator

chalin commented Feb 3, 2024

Great! Thanks for the updates.

@chalin chalin merged commit d0cf645 into google:main Feb 3, 2024
11 checks passed
@deining deining deleted the config-params branch February 4, 2024 09:25
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request user guide Improvements to user guide
Projects
None yet
Milestone
24Q1
Development

Successfully merging this pull request may close these issues.

Do a full review of docs to uniformly apply previous partial fix of param docs
2 participants
@deining @chalin