-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add params to offlineSearch examples #1771
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Your suggestion is valid IMHO, I consider it an improvement to the user guide.
Looking at your changes in search.md
, I realized , that offlineSearch: true
appears two more times in the subchapters Changing the summary length of the local search results
and Changing the maximum result count of the local search
. Shouldn't we mention params
at these occurrences as well? @svrnm: do you want to go for this as well?
Additional note: I just realized that in the chapter documenting how to enable GCSE search engine, the line |
Yes, I can take a look |
Maybe there should be a full review, because there are more references without the params indications : |
@deining done, I fixed the other 2 places as well |
@deining - is this ready? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While trying out the offline search feature I struggled to get it working until I figured out that the `offlineSearch` should be within `params`.
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
thanks for merging :-) |
While trying out the offline search feature I struggled to get it working until I figured out that the
offlineSearch
should be withinparams
.