Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow non alphanumeric characters in enum class names #1297

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Leptopoda
Copy link
Contributor

fixes: #1292

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@davidmorgan
Copy link
Collaborator

Looks good, thanks!

@davidmorgan davidmorgan merged commit c575020 into google:master Jan 12, 2024
3 checks passed
@davidmorgan
Copy link
Collaborator

I'll aim to release next week.

@Leptopoda Leptopoda deleted the feat/enum_dollar_underscore branch January 12, 2024 14:47
@Leptopoda
Copy link
Contributor Author

Hi david, any news on when we can expect the next release?
No pressure but it would be great being able to plan on our side.

@davidmorgan
Copy link
Collaborator

Done! Thanks for your patience :)

And thanks for the improvement and fix, much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow $ in enum class names similar to other built_value classes
2 participants