fix(tools): allow transfer_to_agent to accept extra kwargs #466
+41
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #458
Background
When an LLM‐driven agent called
transfer_to_agent
with extra parameters (e.g.query
,temperature
), the tool raised:because its signature only accepted
agent_name
andtool_context
.With this change, we:
src/google/adk/tools/transfer_to_agent_tool.py
to:kwargs
are silently ignored.tests/integration/tools/test_transfer.py
to include:query
)query
,temperature
,max_tokens
)Each test is parametrized to run against both the GOOGLE_AI and VERTEX backends.
Test Plan
Checklist
Next Steps / TODO
@hangfei @Jacksunwei
Per the existing TODO comment in
transfer_to_agent_tool.py
, we could further internalize this tool (e.g. rename to_transfer_to_agent
or move into aninternal/
submodule) so it doesn’t leak into the public API.I can work on that. Let me know if I can / should?